Skip to content

Commit

Permalink
fix: Prevent drag event from being ignored (#3677)
Browse files Browse the repository at this point in the history
  • Loading branch information
matthewmullin01 committed Feb 9, 2023
1 parent 33ef3f0 commit 2b6e4e3
Showing 1 changed file with 10 additions and 2 deletions.
12 changes: 10 additions & 2 deletions packages/core/src/NodeView.ts
Expand Up @@ -113,11 +113,12 @@ export class NodeView<
return false
}

const isDragEvent = event.type.startsWith('drag')
const isDropEvent = event.type === 'drop'
const isInput = ['INPUT', 'BUTTON', 'SELECT', 'TEXTAREA'].includes(target.tagName) || target.isContentEditable

// any input event within node views should be ignored by ProseMirror
if (isInput && !isDropEvent) {
if (isInput && !isDropEvent && !isDragEvent) {
return true
}

Expand All @@ -129,7 +130,6 @@ export class NodeView<
const isPasteEvent = event.type === 'paste'
const isCutEvent = event.type === 'cut'
const isClickEvent = event.type === 'mousedown'
const isDragEvent = event.type.startsWith('drag')

// ProseMirror tries to drag selectable nodes
// even if `draggable` is set to `false`
Expand Down Expand Up @@ -159,6 +159,14 @@ export class NodeView<
{ once: true },
)

document.addEventListener(
'drop',
() => {
this.isDragging = false
},
{ once: true },
)

document.addEventListener(
'mouseup',
() => {
Expand Down

0 comments on commit 2b6e4e3

Please sign in to comment.