Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(extension-youtube) XSS risk with src tag #4602

Merged
merged 4 commits into from
Nov 20, 2023

Commits on Nov 20, 2023

  1. fix(extension-youtube) XSS risk with src tag

    Fixes risks outline in ueberdosis#4600 by verifying that any src urls are valid
    youtube URLs before rendering as HTML. My thoughts are that this attack
    vector would be difficult to use because the attacker would have to have
    a way to manipualte the TipTap payload in a manner that bypasses the
    youtube extension's `setYoutubeVideo` command, which already checks for
    valid URLs.
    C-Hess authored and janthurau committed Nov 20, 2023
    Configuration menu
    Copy the full SHA
    04a1135 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    7debf2b View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    1bd714a View commit details
    Browse the repository at this point in the history
  4. fix(extension-youtube) fix lint

    C-Hess authored and janthurau committed Nov 20, 2023
    Configuration menu
    Copy the full SHA
    e6947ba View commit details
    Browse the repository at this point in the history