New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(deps): bump prosemirror-trailing-node to 2.0.8 #4949
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for tiptap-embed ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
52f5696
to
ac58c21
Compare
@bdbch @svenadlung - I believe there is a package that is downstream from this one that would benefit from this PR. Are you happy to have a look at this change? It shouldn't change behaviour, and would slightly decrease the total number of dependencies needed for Tiptap. |
793169c
to
ccdc36c
Compare
Seems like this PR only changed the package-lock.json but no package.json? |
@bdbch - that's my fault for not understanding the structure of this repo. I'll put a change in when I get the chance. |
421c99a
to
e688008
Compare
@bdbch - updated the PR so that |
Please describe your changes
Bump prosemirror-trailing-node to 2.0.8 to pick up a change that drops
@remirror/core-helpers
.The latter package was heavy, bringing in several additional dependencies, but was only used to create
an array of unique elements, and to check for the presence of elements in arrays.
Accordingly, they have been replaced in 2.0.8 with equivalent code that relies on standard built-in objects.
How did you accomplish your changes
npm update prosemirror-trailing-node
How have you tested your changes
N/A - trivial dependency upgrade
How can we verify your changes
Ad-hoc testing in dev
Remarks
This PR is submitted through the course of work done for @opengovsg, whose Starter Kit project is dependent on TipTap
Checklist
Related issues
remirror/remirror#2245
remirror/remirror#2247