TS fixes #142
Merged
TS fixes #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`npm install --save-dev typescript @types/node`
…ck-add-ts-tests # Conflicts: # package-lock.json
This was referenced Nov 23, 2022
Closed
|
I would appreciate it if @kachick and @JamieMagee tested this PR to ensure it catches fixes in your respective PRs. |
|
@uhop I validated that the updated types work with TypeScript 4.9 |
|
@uhop If you're happy, can you merge this please? |
|
I have checked #134 patches are still active in this PR 👍 I would add one point, adding CI would be better, to run the new |
JamieMagee
approved these changes
Dec 10, 2022
# Conflicts: # package-lock.json
kachick
added a commit
to kachick/renovate-config-asdf
that referenced
this pull request
Dec 11, 2022
kachick
added a commit
to kachick/renovate-config-asdf
that referenced
this pull request
Dec 11, 2022
* Update dependency re2 to ^1.18.0 * Follow updated signature uhop/node-re2#142 uhop/node-re2@15c7cf6#diff-9170a1e28b63da14692098167202db1b0b63d3ebf239a9ccc107ba20744dfffbL22-R23 Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Kenichi Kamiya <kachick1@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A replacement for #141 and #134.