Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add arm64 Linux prebuilds #203

Merged
merged 2 commits into from
Feb 23, 2024
Merged

Add arm64 Linux prebuilds #203

merged 2 commits into from
Feb 23, 2024

Conversation

cmanou
Copy link
Contributor

@cmanou cmanou commented Jan 11, 2024

  • Should resolve arm64 Linux prebuilts #193
  • Takes the simple approach of just using qemu and running docker on linux/arm64 means that maintenance should be easy at the cost of the build taking around 30 mins for the arm prebuilds compared to 5 mins for the x86 as seen here https://github.com/heydovetail/node-re2/actions/runs/7483714804
  • Once GitHub releases its arm runners we should be able to delete the qemu install and run it directly with docker on the runner with no emulation slow downs.

@uhop uhop self-assigned this Jan 18, 2024
@uhop
Copy link
Owner

uhop commented Jan 23, 2024

Thank you. It looks like what we need. Let me test it a little bit more and I'll package it in the next release.

@uhop uhop merged commit 8b49721 into uhop:master Feb 23, 2024
9 checks passed
@bradleyayers bradleyayers deleted the cmanou/arm-linux branch February 24, 2024 11:12
@uhop
Copy link
Owner

uhop commented Mar 3, 2024

Published as 1.20.10.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

arm64 Linux prebuilts
2 participants