Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

don't change top-level html style in scope mode #3746

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

don't change top-level html style in scope mode #3746

wants to merge 1 commit into from

Conversation

akihiro-nagai
Copy link

@akihiro-nagai akihiro-nagai commented Feb 1, 2019 •
edited

This PR prevents from changing top-level <html> style in scope mode.

I noticed that uikit.css executed yarn scope still has html { * }.
This is possible to affect existing styles.

Normally, scope mode is used like following code, according to documents (https://getuikit.com/docs/avoiding-conflicts#scope-mode)

<div class="uk-scope">
    <!-- your UIkit markup -->
    ...
</div>

So, we use .uk-scope instead of html to use scope-mode safley.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@akihiro-nagai