UIKit 4: Start using logical properties #4170
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janschoenherr
force-pushed
the
develop
branch
from
ec95eb0
to
256dc87
Compare
janschoenherr
force-pushed
the
develop
branch
from
a3880a1
to
bf937dd
Compare
janschoenherr
force-pushed
the
develop
branch
2 times, most recently
from
6c18132
to
ae16f4d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assuming UIKit 4 will not support IE11, this PR replaces
leftandrighttext alignments withstartandend.The benefit of this is that properties do not need to be reversed for RTL mode...it's done automatically by the browser.
If this is accepted, I'll be more than happy to start working on other logical properties, such as:
There are certain logical properties that are still unsuupported (mainly by Safari), but I reckon they'll start supporting them in the not too distant future