fix(web-component): fix anchor click issue.

uiwjs · Apr 1, 2022 · a3e7654 · a3e7654
1 parent 7747a00
commit a3e7654
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 15 deletions.
diff --git a/web-component/demo.html b/web-component/demo.html
@@ -8,7 +8,7 @@
   <script type="module" src="./lib/index.js"></script>
 </head>
 <body>
-  <github-corners aria-label="View source on GitHub" fill="red" color="blue" target="__blank" href="https://github.com/uiwjs/react-github-corners"></github-corners>
+  <github-corners position="fixed" aria-label="View source on GitHub" fill="red" color="blue" target="__blank" href="https://github.com/uiwjs/react-github-corners"></github-corners>
   <label>
     <input type="range" value="160" min="50" max="220" onChange="handleChange(this)" />
   </label>
@@ -21,5 +21,6 @@
       corner.setAttribute('height', target.value);
     }
   </script>
+  <div style="height: 1200px;"></div>
 </body>
 </html>
diff --git a/web-component/src/index.ts b/web-component/src/index.ts
@@ -37,13 +37,15 @@ TEMPLATE.innerHTML = `
   }
 }
 </style>
-<a id="warpper">
-  <svg width="80" height="80" viewBox="0 0 250 250" aria-hidden="true" style="fill: rgb(21, 21, 19); color: rgb(255, 255, 255); position: absolute; border: 0px; top: 0px;">
-    <path d="M0,0 L115,115 L130,115 L142,142 L250,250 L250,0 Z"></path>
-    <path d="M128.3,109.0 C113.8,99.7 119.0,89.6 119.0,89.6 C122.0,82.7 120.5,78.6 120.5,78.6 C119.2,72.0 123.4,76.3 123.4,76.3 C127.3,80.9 125.5,87.3 125.5,87.3 C122.9,97.6 130.6,101.9 134.4,103.2" fill="currentColor" class="octo-arm" style="transform-origin: 130px 106px;"></path>
-    <path d="M115.0,115.0 C114.9,115.1 118.7,116.5 119.8,115.4 L133.7,101.6 C136.9,99.2 139.9,98.4 142.2,98.6 C133.8,88.0 127.5,74.4 143.8,58.0 C148.5,53.4 154.0,51.2 159.7,51.0 C160.3,49.4 163.2,43.6 171.4,40.1 C171.4,40.1 176.1,42.5 178.8,56.2 C183.1,58.6 187.2,61.8 190.9,65.4 C194.5,69.0 197.7,73.2 200.1,77.6 C213.8,80.2 216.3,84.9 216.3,84.9 C212.7,93.1 206.9,96.0 205.4,96.6 C205.1,102.4 203.0,107.8 198.3,112.5 C181.9,128.9 168.3,122.5 157.7,114.1 C157.9,116.9 156.7,120.9 152.7,124.9 L141.0,136.5 C139.8,137.7 141.6,141.9 141.8,141.8 Z" fill="currentColor" class="octo-body"></path>
-  </svg>
-</a>
+<svg width="80" height="80" viewBox="0 0 250 250" aria-hidden="true" style="position: absolute; border: 0px; top: 0px;">
+  <a xlink:href="https://github.com/uiwjs/react-github-corners" target="_blank" rel="nofollow sponsored" style="fill: rgb(21, 21, 19); color: rgb(255, 255, 255);">
+    <g>
+      <path d="M0,0 L115,115 L130,115 L142,142 L250,250 L250,0 Z"></path>
+      <path d="M128.3,109.0 C113.8,99.7 119.0,89.6 119.0,89.6 C122.0,82.7 120.5,78.6 120.5,78.6 C119.2,72.0 123.4,76.3 123.4,76.3 C127.3,80.9 125.5,87.3 125.5,87.3 C122.9,97.6 130.6,101.9 134.4,103.2" fill="currentColor" class="octo-arm" style="transform-origin: 130px 106px;"></path>
+      <path d="M115.0,115.0 C114.9,115.1 118.7,116.5 119.8,115.4 L133.7,101.6 C136.9,99.2 139.9,98.4 142.2,98.6 C133.8,88.0 127.5,74.4 143.8,58.0 C148.5,53.4 154.0,51.2 159.7,51.0 C160.3,49.4 163.2,43.6 171.4,40.1 C171.4,40.1 176.1,42.5 178.8,56.2 C183.1,58.6 187.2,61.8 190.9,65.4 C194.5,69.0 197.7,73.2 200.1,77.6 C213.8,80.2 216.3,84.9 216.3,84.9 C212.7,93.1 206.9,96.0 205.4,96.6 C205.1,102.4 203.0,107.8 198.3,112.5 C181.9,128.9 168.3,122.5 157.7,114.1 C157.9,116.9 156.7,120.9 152.7,124.9 L141.0,136.5 C139.8,137.7 141.6,141.9 141.8,141.8 Z" fill="currentColor" class="octo-body"></path>
+    </g>
+  </a>
+</svg>
 `;
 
 export class GithubCorners extends HTMLElement {
@@ -61,7 +63,7 @@ export class GithubCorners extends HTMLElement {
   right?: string = '0';
   bottom?: string;
   transform?: string;
-  warpper?: HTMLElement;
+  private shadow: ShadowRoot
   static get observedAttributes(): string[] {
     return ['z-index', 'target', 'height', 'width', 'href', 'color', 'fill', 'position', 'top', 'left', 'right', 'bottom', 'transform'];
   }
@@ -70,20 +72,18 @@ export class GithubCorners extends HTMLElement {
     this.initDom();
   }
   private initDom() {
-    const shadow = this.attachShadow({ mode: 'open' });
-    shadow.appendChild(this.ownerDocument.importNode(TEMPLATE.content, true));
-    this.warpper = shadow.getElementById('warpper');
-
+    this.shadow = this.attachShadow({ mode: 'open' });
+    this.shadow.appendChild(this.ownerDocument.importNode(TEMPLATE.content, true));
     this.update();
   }
   private update() {
-    const svg = this.warpper.querySelector('svg')
+    const svg = this.shadow.querySelector('svg')
     ;[...this.getAttributeNames(), 'right'].forEach((name) => {
       const value = this.getAttribute(name) || this[name as keyof GithubCorners] as any || '';
       if (/(z-index|height|width|color|fill|position|top|left|right|bottom|transform)/.test(name.toLocaleLowerCase())) {
         svg.style[name as any] = value;
       } else {
-        this.warpper.setAttribute(name, value);
+        svg.setAttribute(name, value);
       }
     });
   }