Swap out connected-react-router for redux-first-history #4971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test summaryRun details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
paulgain
force-pushed
the
fix/remove-connected-react-router
branch
2 times, most recently
from
4d058cb
to
e69710f
Compare
|
When trying to add a duplicate contact to Data Hub this is the redux error(5), at this point the UI hangs. This error doesn't exist in
|
paulgain
force-pushed
the
fix/remove-connected-react-router
branch
from
e69710f
to
aff3ccb
Compare
paulgain
force-pushed
the
fix/remove-connected-react-router
branch
from
aff3ccb
to
807fd2c
Compare
paulgain
force-pushed
the
fix/remove-connected-react-router
branch
from
807fd2c
to
5ebbdf7
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
As part of upgrading
react-router-domtov6fromv5we need to swap outconnected-react-routerforredux-first-history(open to alternatives) as a prerequisite to the upgrade. Unfortunately,connected-react-routeronly has a redux binding for React Routerv4andv5whereasredux-first-historygives us av6binding. In addition,connected-react-routerappears to be minimally maintained, only security vulnerabilities are addressed despite multiple dev requests to upgrade the package going back to the 4th November 2021.This PR simply swaps out the two in preparation for the
react-router-domupgrade.Test instructions
Everything should be as it was, there are no visual changes.
Checklist