Support witnesses with ghost variables #653
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danieldietsch
approved these changes
Oct 26, 2023
bahnwaerter
requested changes
Oct 26, 2023
There was a problem hiding this comment.
Thanks @schuessf for your great work. Your changes look good to me. However, make sure that new files always contain a license header.
...k/ultimate/plugins/generator/cacsl2boogietranslator/witness/ExtractedCorrectnessWitness.java
Show resolved
Hide resolved
...formatik/ultimate/plugins/generator/cacsl2boogietranslator/witness/ExtractedGhostUpdate.java
Show resolved
Hide resolved
...rmatik/ultimate/plugins/generator/cacsl2boogietranslator/witness/ExtractedGhostVariable.java
Show resolved
Hide resolved
.../ultimate/plugins/generator/cacsl2boogietranslator/witness/IExtractedWitnessDeclaration.java
Show resolved
Hide resolved
...ce/WitnessParser/src/de/uni_freiburg/informatik/ultimate/witnessparser/yaml/GhostUpdate.java
Show resolved
Hide resolved
.../WitnessParser/src/de/uni_freiburg/informatik/ultimate/witnessparser/yaml/GhostVariable.java
Show resolved
Hide resolved
...nessParser/src/de/uni_freiburg/informatik/ultimate/witnessparser/yaml/ILocationProvider.java
Outdated
Show resolved
Hide resolved
bahnwaerter
approved these changes
Oct 26, 2023
|
Needs to be revised (after SV-COMP), because the format for YAML witnesses has changed and we also use a different parser. |
schuessf
force-pushed
the
wip/fs/witness-ghost
branch
from
5734683
to
3a3bcc2
Compare
schuessf
force-pushed
the
wip/fs/witness-ghost
branch
4 times, most recently
from
8394148
to
6fc2df3
Compare
schuessf
force-pushed
the
wip/fs/witness-ghost
branch
from
e40b1f5
to
8d13ce8
Compare
(if multiple ghost update occur at the same location)
schuessf
force-pushed
the
wip/fs/witness-ghost
branch
from
8d13ce8
to
b44c828
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the validation of witnesses that contain ghost variables. Namely the entry-types (that are not official yet) in YAML-witnesses
ghost_variableandghost_updatecan now be handled in the validation. The validation of those entry-types works in a similar fashion to the existing entry-type invariant: We translate them to ACSL, s.t. the entries instrumented are in our Boogie-Code. This instrumentation uses ghost code in ACSL that is now supported (see #649).