Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump vite from 3.2.4 to 4.0.1 #304

Closed
wants to merge 3 commits into from
Closed

Bump vite from 3.2.4 to 4.0.1 #304

wants to merge 3 commits into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Dec 13, 2022 •
edited

Bumps vite from 3.2.4 to 4.0.1.

Release notes

Sourced from vite's releases.

create-vite@4.0.0

Please refer to CHANGELOG.md for details.

create-vite@4.0.0-beta.0

Please refer to CHANGELOG.md for details.

Changelog

Sourced from vite's changelog.

4.0.1 (2022-12-12)

4.0.0 (2022-12-09)

Vite 4 Announcement Cover Image

Read the announcement blog post: Announcing Vite 4

Quick links:

Docs in other languages:

Main Changes

This major is smaller in scope compared to Vite 3, with the main objective of upgrading to Rollup 3. We've worked with the ecosystem to ensure a smooth upgrade path for this new major.

Rollup 3

Vite is now using Rollup 3, which allowed us to simplify Vite's internal asset handling and has many improvements. See the Rollup 3 release notes here.

Framework Plugins out of the Vite core monorepo

@vitejs/plugin-vue and @vitejs/plugin-react have been part of Vite core monorepo since the first versions of Vite. This helped us to get a close feedback loop when making changes as we were getting both Core and the plugins tested and released together. With vite-ecosystem-ci we can get this feedback with these plugins developed on independent repositories, so from Vite 4, they have been moved out of the Vite core monorepo. This is meaningful for Vite's framework-agnostic story, and will allow us to build independent teams to maintain each of the plugins. If you have bugs to report or features to request, please create issues on the new repositories moving forward: vitejs/vite-plugin-vue and vitejs/vite-plugin-react.

... (truncated)

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Dec 13, 2022
@dependabot dependabot bot mentioned this pull request Dec 13, 2022
Closed
@nielslyngsoe nielslyngsoe marked this pull request as draft December 13, 2022 10:11
@nielslyngsoe
Copy link
Member

This gives problems with our import statement in this file /src/core/extensions-api/load-extension.function.ts.

This gives us the issue:

The above dynamic import cannot be analyzed by Vite. See https://github.com/rollup/plugins/tree/master/packages/dynamic-import-vars#limitations for supported dynamic import formats. If this is intended to be left as-is, you can use the /* @vite-ignore */ comment inside the import() call to suppress this warning.

Which is already done. So it needs further investigation to be fixed. As this is relatively new there is still no issue with this specific problem. So let's return to this in a bit.

@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/vite-4.0.1 branch 2 times, most recently from fa849c6 to 0f85cbc Compare December 15, 2022 12:12
@dependabot
Bump vite from 3.2.4 to 4.0.1
0f67084 
Bumps [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite) from 3.2.4 to 4.0.1.
- [Release notes](https://github.com/vitejs/vite/releases)
- [Changelog](https://github.com/vitejs/vite/blob/main/packages/vite/CHANGELOG.md)
- [Commits](https://github.com/vitejs/vite/commits/v4.0.1/packages/vite)

---
updated-dependencies:
- dependency-name: vite
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/vite-4.0.1 branch from 0f85cbc to 0f67084 Compare December 16, 2022 08:05
@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://ashy-bay-09f36a803-304.westeurope.1.azurestaticapps.net

@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://ambitious-stone-0033b3603-304.westeurope.1.azurestaticapps.net

@github-actions
Copy link

LCOV of commit f668410 during Build and test #907

Summary coverage rate:
  lines......: 65.9% (4078 of 6190 lines)
  functions..: 49.2% (160 of 325 functions)
  branches...: 86.7% (255 of 294 branches)

Files changed coverage rate: n/a

@iOvergaard
Copy link
Collaborator

Looks like Vite broke their own notifier here as they are scraping the comment away that should prevent the warning. Let's just wait for an eventual bugfix.

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Dec 19, 2022

A newer version of vite exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged.

@github-actions
Copy link

LCOV of commit df443cd during Build and test #932

Summary coverage rate:
  lines......: 65.9% (4078 of 6190 lines)
  functions..: 49.2% (160 of 325 functions)
  branches...: 86.7% (255 of 294 branches)

Files changed coverage rate: n/a

@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://ashy-bay-09f36a803-304.westeurope.1.azurestaticapps.net

@iOvergaard
Copy link
Collaborator

This currently leaves a warning in console when building because of upstream issues: vitejs/vite#11377

@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://ambitious-stone-0033b3603-304.westeurope.1.azurestaticapps.net

@nielslyngsoe nielslyngsoe self-requested a review January 2, 2023 14:21
@iOvergaard
Copy link
Collaborator

@dependabot recreate

@iOvergaard iOvergaard closed this Jan 11, 2023
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Jan 11, 2023

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/npm_and_yarn/vite-4.0.1 branch January 11, 2023 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iOvergaard iOvergaard Awaiting requested review from iOvergaard

@nielslyngsoe nielslyngsoe Awaiting requested review from nielslyngsoe

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nielslyngsoe @iOvergaard