Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introducing the Delay Queue #74

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

rommelsv
Copy link

Implementation of the Delay Queue, an extra delay for all memory transactions in the memory controller.

Copy link
Collaborator

@shavvn shavvn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The delayedInfo class definition seems to be missing. Can you make sure you included all the changes made in order to build the code successfully? Thanks!

@shavvn shavvn self-assigned this Sep 29, 2018
Changes to be committed:
	modified:   MultiChannelMemorySystem.h
@rommelsv
Copy link
Author

rommelsv commented Oct 2, 2018

Hi Shawn.
I've committed it. Sorry for the inconvenience.

Copy link
Collaborator

@shavvn shavvn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @rommelsv ,

Thanks for the patch.

I was able to build after your commit. But I think there's still some problems that I can see now:

  1. There's no default parameter provided for DQ_DEPTH, which I assume will be in sys.ini, right?

  2. I tried to add a DQ_DEPTH=20 to sys.ini and ran a few experiments, but it doesn't look like the program took it as an input. I think it should be included in configmap of IniReader.cpp. (I saw you had it but somehow commented it out?)

@rommelsv
Copy link
Author

HI Shavvn,
Are you testing with traces?
We implemented the Delay Queue (DQ) as part of this integration with a CPU simulator. So it is only visible right now from the DRAMSim2 perspective if the libdramsim is used.
Moreover, if DQ_DEPTH is not present in the sys config file, a value of 0 is considered and the logic is the same as without the patch.
But if is present, DQ comes to place when the actual_update() function is called.
We designed it like this to avoid noise with the current DRAMSim2 users. This way, they can still use the simulator without the effects of the DQ.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants