feat: support babel runtime version #239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afc163
commented
Jul 30, 2020
| var _classCallCheck2 = _interopRequireDefault( | ||
| require("@babel/runtime/helpers/classCallCheck") | ||
| ); | ||
| var _objectSpread2 = _interopRequireDefault(require("@babel/runtime/helpers/objectSpread2")); |
There was a problem hiding this comment.
不开启 version，这个不会走 @babel/runtime。
Codecov Report
@@ Coverage Diff @@
## 2.x #239 +/- ##
==========================================
+ Coverage 73.39% 73.56% +0.17%
==========================================
Files 16 16
Lines 466 469 +3
Branches 158 160 +2
==========================================
+ Hits 342 345 +3
Misses 123 123
Partials 1 1
Continue to review full report at Codecov.
|
|
依赖多的时候可以进一步优化打包体积：ant-design/ant-design#22698 |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm testpassesDescription of change
close #224
参考 babel/babel#10261 。
开启 version 参数，解决
ownKeys和_objectSpread没有走 @babel/runtime 的问题。比如：https://unpkg.com/browse/rc-select@11.1.0/es/generate.js