Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: useLayoutEffect will be warning in ssr mode #533

Merged
merged 2 commits into from Feb 20, 2021
Merged

fix: useLayoutEffect will be warning in ssr mode #533

merged 2 commits into from Feb 20, 2021

Conversation

moecasts
Copy link
Contributor

@moecasts moecasts commented Feb 5, 2021

close #532
Close umijs/umi#5684

@codecov
Copy link

codecov bot commented Feb 5, 2021

Codecov Report

Merging #533 (d3fb98b) into master (303787f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #533   +/-   ##
=======================================
  Coverage   47.63%   47.63%           
=======================================
  Files          66       66           
  Lines        1541     1541           
  Branches      423      423           
=======================================
  Hits          734      734           
  Misses        806      806           
  Partials        1        1           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 303787f...d3fb98b. Read the comment docs.

Copy link
Contributor

@ycjcl868 ycjcl868 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants