Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(esbuild): set utf-8 charset for esbuild #10021

Closed
wants to merge 1 commit into from

Conversation

fz6m
Copy link
Member

@fz6m fz6m commented Dec 9, 2022

原因:esbuild 默认 ascii 编码产物会非常大。

See vitejs/vite#10753

@vercel
Copy link

vercel bot commented Dec 9, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
umi ⬜️ Ignored (Inspect) Dec 9, 2022 at 6:50PM (UTC)

@codecov
Copy link

codecov bot commented Dec 9, 2022

Codecov Report

Base: 30.36% // Head: 30.36% // No change to project coverage 👍

Coverage data is based on head (5d065ac) compared to base (87854d8).
Patch coverage: 80.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #10021   +/-   ##
=======================================
  Coverage   30.36%   30.36%           
=======================================
  Files         432      432           
  Lines       12333    12333           
  Branches     2946     2946           
=======================================
  Hits         3745     3745           
  Misses       8027     8027           
  Partials      561      561           
Impacted Files Coverage Δ
packages/bundler-esbuild/src/build.ts 100.00% <ø> (ø)
packages/bundler-utils/src/index.ts 0.00% <ø> (ø)
packages/bundler-vite/src/plugins/svgr.ts 52.63% <ø> (ø)
...kages/bundler-webpack/src/config/compressPlugin.ts 31.91% <ø> (ø)
packages/bundler-webpack/src/loader/svgr.ts 81.25% <ø> (ø)
packages/mfsu/src/dep/getModuleExports.ts 23.52% <ø> (ø)
packages/mfsu/src/loader/esbuild.ts 0.00% <0.00%> (ø)
packages/plugins/src/utils/modelUtils.ts 64.12% <ø> (ø)
...et-umi/src/features/apiRoute/dev-server/esbuild.ts 0.00% <ø> (ø)
...preset-umi/src/features/apiRoute/vercel/esbuild.ts 0.00% <ø> (ø)
... and 11 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sorrycc
Copy link
Member

sorrycc commented Dec 11, 2022

1、对于中文场景,我理解 ascii 更好点,不会导致运行时的编码问题
2、如果要加需要用配置项加,直接改 utf-8 会有 break change

@fz6m
Copy link
Member Author

fz6m commented Dec 11, 2022

已切换到 #10030

@fz6m fz6m closed this Dec 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants