Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/mfsu rebuild when patch #10065

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

mysteryven
Copy link
Contributor

support #10064

@vercel
Copy link

vercel bot commented Dec 14, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
umi ⬜️ Ignored (Inspect) Dec 17, 2022 at 1:13PM (UTC)

@codecov
Copy link

codecov bot commented Dec 14, 2022

Codecov Report

❗ No coverage uploaded for pull request base (master@835d353). Click here to learn what that means.
Patch coverage: 93.61% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff            @@
##             master   #10065   +/-   ##
=========================================
  Coverage          ?   30.36%           
=========================================
  Files             ?      433           
  Lines             ?    12431           
  Branches          ?     2976           
=========================================
  Hits              ?     3775           
  Misses            ?     8089           
  Partials          ?      567           
Impacted Files Coverage Δ
packages/mfsu/src/staticDepInfo/staticDepInfo.ts 29.32% <80.00%> (ø)
packages/mfsu/src/depInfo.ts 64.44% <90.90%> (ø)
packages/mfsu/src/utils/patchesHashUtil.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

packages/mfsu/src/depInfo.ts Outdated Show resolved Hide resolved
packages/mfsu/src/utils/depInfoUtil.ts Outdated Show resolved Hide resolved
packages/mfsu/src/utils/depInfoUtil.ts Outdated Show resolved Hide resolved
packages/mfsu/src/staticDepInfo/staticDepInfo.ts Outdated Show resolved Hide resolved
packages/mfsu/src/utils/depInfoUtil.ts Outdated Show resolved Hide resolved
@mysteryven
Copy link
Contributor Author

mysteryven commented Dec 16, 2022

@fz6m

首先非常感谢您一直认真的帮我找出代码规范的问题。看着每次 PR 都有那么多问题,找出来一定很辛苦,并且不是一个愉快的工作,我也觉得挺过意不去。但是目前自己认知水平达不到,在提交之前也看不出问题。

请问可以给一个您认可的编码规范的文档吗?虽然有些情形考虑不到,还是需要别人指点,但是我也希望提交的代码在代码风格上尽量别再有这么多的问题 =.=

@fz6m
Copy link
Member

fz6m commented Dec 16, 2022

我是很久以前看过一些零散的文章,不过你可以去 juejin 搜一下 代码风格 ,我看了下很多文章都有总结。

关于 code style ,我提的建议也是自己的看法,见仁见智,千人千面。

@fz6m
Copy link
Member

fz6m commented Dec 17, 2022

上次看你的提交,如果对 TypeScript 的类型不熟,可以用 typescript 万字长文类型体操typescript 高级类型typescript 泛型 关键词搜一些文章看看。

这里还有一些题目可以看看:https://github.com/type-challenges/type-challenges

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants