Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: upgrade node to 18 #12380

Merged
merged 1 commit into from
May 16, 2024
Merged

docs: upgrade node to 18 #12380

merged 1 commit into from
May 16, 2024

Conversation

hualigushi
Copy link
Contributor

@hualigushi hualigushi commented May 12, 2024

文档 node 版本版本更新到 18

Summary by CodeRabbit

  • 文档更新
    • 更新了各文档中对 Node.js 版本的要求,从 14+ 或 16+ 提升至 18+。
    • 调整了相关的 Node.js 安装和使用命令,以反映版本变更。

Copy link

vercel bot commented May 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
umi ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 12, 2024 6:27am

Copy link

coderabbitai bot commented May 12, 2024

概述

这次修改主要更新了项目中所需的 Node.js 版本,从 14 或 16 升级到 18。这一改变体现在多个文档中,涉及环境设置指南和 Umi.js 开发的要求。

变更

文件路径 变更摘要
.../getting-started.* 更新环境设置中的 Node.js 版本要求从 14 或 16 升级到 18。
.../guides/prepare.* 将 Umi.js 开发所需的 Node.js 版本从 14 升级到 18。
.../introduce/contributing.* 将开发 Umi 所需的 Node.js 版本从 16+ 升级到 18+。

🐰 诗歌庆祝变更

在代码的世界里跳跃,
小兔子带来新的节拍。
Node升级,轻轻松松,
从14跳到18,真给力!
🌟🌟🌟🌟🌟
——编码小兔


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between c7f61e9 and d7150b4.
Files selected for processing (6)
  • docs/docs/docs/guides/getting-started.en-US.md (2 hunks)
  • docs/docs/docs/guides/getting-started.md (2 hunks)
  • docs/docs/docs/guides/prepare.en-US.md (2 hunks)
  • docs/docs/docs/guides/prepare.md (2 hunks)
  • docs/docs/docs/introduce/contributing.en-US.md (1 hunks)
  • docs/docs/docs/introduce/contributing.md (1 hunks)
Files skipped from review due to trivial changes (1)
  • docs/docs/docs/guides/prepare.en-US.md
Additional comments not posted (9)
docs/docs/docs/guides/prepare.md (3)

12-12: 确保 Node.js 版本信息更新准确无误。


31-32: 更新 Node.js 版本的命令已正确修改为18,符合文档整体更新目的。


40-40: 示例中显示的 Node.js 版本已更新至 v18.14.0,与文档中的要求一致。

docs/docs/docs/introduce/contributing.md (1)

14-14: 更新了开发 Umi 所需的 Node.js 版本要求至18+,确保文档与实际开发环境要求一致。

docs/docs/docs/guides/getting-started.md (2)

9-9: 更新了 Node.js 版本要求至18或以上,与项目的最新要求保持一致。


22-25: Node.js 安装和使用的命令已正确更新至版本18,确保用户按照最新的指南操作。

docs/docs/docs/guides/getting-started.en-US.md (2)

11-11: 确保 Node.js 版本信息更新准确无误,与中文版本保持一致。


24-27: Node.js 安装和使用的命令已正确更新至版本18,确保用户按照最新的指南操作。

docs/docs/docs/introduce/contributing.en-US.md (1)

15-15: 更新了开发 Umi 所需的 Node.js 版本要求至18+,确保文档与实际开发环境要求一致。

Copy link

codecov bot commented May 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.39%. Comparing base (8d307e8) to head (d7150b4).
Report is 20 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #12380      +/-   ##
==========================================
- Coverage   28.40%   28.39%   -0.02%     
==========================================
  Files         492      494       +2     
  Lines       15171    15248      +77     
  Branches     3630     3653      +23     
==========================================
+ Hits         4310     4330      +20     
- Misses      10088    10142      +54     
- Partials      773      776       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fz6m
Copy link
Member

fz6m commented May 12, 2024

不改代码里的版本校验吗?这是针对 mako 需要的 node 18 么。

@hualigushi
Copy link
Contributor Author

目前 node 16 已经不维护了~ 我们文档里面推荐用 16 的地方 改成 18 吧 --- BY 辟殊

@PeachScript PeachScript changed the title docs: node 版本更新到 18 docs: upgrade node to 18 May 16, 2024
@PeachScript PeachScript merged commit 11ebbad into master May 16, 2024
24 checks passed
@delete-merged-branch delete-merged-branch bot deleted the feat/doc-node18-qly branch May 16, 2024 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants