Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: workaround to resolve core-js path error bug #5719

Merged
merged 1 commit into from Nov 23, 2020
Merged

Conversation

PeachScript
Copy link
Member

Checklist
  • npm test passes
  • commit message follows commit guidelines
Description of change

Process require statements in core-js lock plugin, but the real reason that caused the import statements transform to require statements still not found.

Copy link
Member

@sorrycc sorrycc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

还是得找到根源,谁改的 import -> require 。

@PeachScript
Copy link
Member Author

还是得找到根源,谁改的 import -> require 。

是的,主要现在答疑人数激增,先把问题 workaround 掉,我们在持续排查

@ycjcl868 ycjcl868 merged commit 7762d90 into 2.x Nov 23, 2020
@delete-merged-branch delete-merged-branch bot deleted the hotfix/lock-core-js branch November 23, 2020 09:48
@afc163
Copy link
Contributor

afc163 commented Nov 23, 2020

看看 babel/babel#12340 有没有关系?

@ycjcl868
Copy link
Contributor

看看 babel/babel#12340 有没有关系?

可能相关

umi 的复现 demo: https://github.com/ycjcl868/umi-2-core-js-bug

@ycjcl868
Copy link
Contributor

ycjcl868 commented Nov 23, 2020

确认了,是这一行导致 babel/babel#12331

@nicolo-ribaudo
Copy link

Not directly related to this bug, but you can probably remove this custom plugin by doing something like storybookjs/storybook#13055 (so that Babel already inject imports to the correct core-js path).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants