fix(run): tsx bin path #9152
Merged
fix(run): tsx bin path #9152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Codecov Report
@@ Coverage Diff @@
## master #9152 +/- ##
=======================================
Coverage 30.53% 30.53%
=======================================
Files 403 403
Lines 11009 11009
Branches 2642 2642
=======================================
Hits 3362 3362
Misses 7160 7160
Partials 487 487
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
fz6m
commented
Aug 29, 2022
| @@ -49,9 +49,10 @@ export default (api: IApi) => { | |||
| }; | |||
|
|
|||
| export function getBinPath() { | |||
| const pkgPath = join(__dirname, '../node_modules/tsx/package.json'); | |||
| // tsx does not export `package.json` subpath, use `resolve` instead of `require.resolve` | |||
| const pkgPath = resolve.sync('tsx/package.json', { basedir: __dirname }); | |||
There was a problem hiding this comment.
Try resolve in privatenumber/tsx#91
sorrycc
approved these changes
Aug 30, 2022
ye-will
pushed a commit
to ye-will/umi
that referenced
this pull request
Sep 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #9148