Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add experimental-loader for Yarn PnP #105

Closed
wants to merge 1 commit into from

Conversation

lachlanhunt
Copy link

Adding the experimental-loader for PnP to resolve the remaining issue with loading mjs workers within synckit.

I currently don't have a test case within this repo's test suite that can demonstrate this because the difficulty is that this repo itself it not actually using Yarn PnP, and doesn't have dependencies stored within zip files. I don't yet know if writing a test case for it in this test suite is possible.

At this stage, I can only confirm that the test script I commented about in the other PR only succeeds when run within a repo using PnP and with a patched version of synckit that includes this change.

@changeset-bot
Copy link

changeset-bot bot commented Aug 10, 2022

⚠️ No Changeset found

Latest commit: 5a6fa16

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@github-actions
Copy link
Contributor

📊 Package size report   No changes

File Before After
Total (Includes all files) 44.2 kB 44.2 kB
Tarball size 12.1 kB 12.1 kB
Unchanged files
File Size
lib/index.cjs 9.5 kB
lib/index.d.ts 1.3 kB
lib/index.js 10.7 kB
lib/index.js.map 9.0 kB
lib/types.d.ts 936 B
lib/types.js 44 B
lib/types.js.map 102 B
LICENSE 1.1 kB
package.json 4.0 kB
README.md 7.6 kB

🤖 This report was automatically generated by pkg-size-action

@JounQin
Copy link
Member

JounQin commented Aug 10, 2022

@lachlanhunt Thanks for your contribution first! But I'm sorry it has been fixed by #103.

@JounQin JounQin closed this Aug 10, 2022
@JounQin
Copy link
Member

JounQin commented Aug 10, 2022

Besides, we do have test case for yarn PnP at https://github.com/un-ts/synckit/blob/main/test/fixtures/yarn-pnp.spec.ts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants