Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support yarn PnP out of box, propagate PnP runtime #98

Merged
merged 8 commits into from Aug 10, 2022
Merged

feat: support yarn PnP out of box, propagate PnP runtime #98

Changes from 3 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
a69e0bc
feat: forward pnp runtime if parent process uses pnp
Aug 4, 2022
4bcf636
cr: update src/index.ts
noahnu Aug 9, 2022
5980490
wip: split -r from path
Aug 9, 2022
f0ed716
Update src/index.ts
JounQin Aug 9, 2022
a2ebb62
test: add fixtures test cases
JounQin Aug 9, 2022
ebc72eb
test: use execa for executing scripts
JounQin Aug 9, 2022
058baa9
refactor: check NODE_OPTIONS env more gracefully
JounQin Aug 10, 2022
1b43e6d
Create light-comics-smell.md
JounQin Aug 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
13 changes: 13 additions & 0 deletions src/index.ts
View file
Open in desktop
Expand Up @@ -42,6 +42,7 @@ const {
SYNCKIT_TIMEOUT,
SYNCKIT_EXEC_ARGV,
SYNCKIT_TS_RUNNER,
NODE_OPTIONS,
} = process.env

export const DEFAULT_BUFFER_SIZE = SYNCKIT_BUFFER_SIZE
Expand Down Expand Up @@ -209,6 +210,18 @@ const setupTsRunner = (
}
}

if (process.versions.pnp) {
try {
const resolvedPnp = require.resolve('pnpapi')
JounQin marked this conversation as resolved.
Show resolved Hide resolved
if (
!NODE_OPTIONS?.includes(resolvedPnp) &&
noahnu marked this conversation as resolved.
Show resolved Hide resolved
!execArgv.includes(resolvedPnp)
) {
execArgv.push('-r', resolvedPnp)
}
} catch {}
JounQin marked this conversation as resolved.
Show resolved Hide resolved
}

return {
ext,
isTs,
Expand Down