Skip to content

Commit

Permalink
fix(ui5-color-palette): remove deprecated API's
Browse files Browse the repository at this point in the history 
Related to: SAP#4460
  • Loading branch information
@unazko
unazko committed Mar 25, 2024
1 parent 0789c34 commit 7ad0cec
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 37 deletions.
25 changes: 0 additions & 25 deletions packages/main/src/ColorPalettePopover.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -166,31 +166,6 @@ class ColorPalettePopover extends UI5Element {
return this.shadowRoot!.querySelector<ResponsivePopover>("[ui5-responsive-popover]")!;
}

/**
* Shows the ColorPalettePopover.
* @param opener the element that the popover is shown at
* @public
* @deprecated The method is deprecated in favour of `open` and `opener` properties.
* @since 1.1.1
*/
showAt(opener: HTMLElement): void {
console.warn("The method 'showAt' is deprecated and will be removed in future, use 'open' and 'opener' props instead."); // eslint-disable-line
this.open = true;
this.opener = opener;
}

/**
* Shows the ColorPalettePopover.
* @param opener the element that the popover is shown at
* @public
* @since 1.0.0-rc.16
* @deprecated The method is deprecated in favour of `open` and `opener` properties.
*/
openPopover(opener: HTMLElement): void {
console.warn("The method 'openPopover' is deprecated and will be removed in future, use 'open' and 'opener' props instead."); // eslint-disable-line
this.showAt(opener);
}

closePopover() {
this.open = false;
}
Expand Down
24 changes: 12 additions & 12 deletions packages/main/test/pages/ColorPalettePopover.html
View file
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@

<ui5-title level="H5">Test case 1 - Default Color Button to be focused</ui5-title>
<ui5-button id="colorPaletteBtnTest">Open</ui5-button>
<ui5-color-palette-popover id="colorPalettePopoverTest" show-recent-colors show-more-colors show-default-color default-color="green">
<ui5-color-palette-popover id="colorPalettePopoverTest" show-recent-colors show-more-colors show-default-color default-color="green" opener="colorPaletteBtnTest">
<ui5-color-palette-item value="pink"></ui5-color-palette-item>
<ui5-color-palette-item value="darkblue"></ui5-color-palette-item>
<ui5-color-palette-item value="#444444"></ui5-color-palette-item>
Expand All @@ -31,7 +31,7 @@

<ui5-title level="H5">Test case 2 - Default Color works</ui5-title>
<ui5-button id="colorPaletteBtnTest2">Open</ui5-button>
<ui5-color-palette-popover id="colorPalettePopoverTest2" show-recent-colors show-more-colors show-default-color default-color="green">
<ui5-color-palette-popover id="colorPalettePopoverTest2" show-recent-colors show-more-colors show-default-color default-color="green" opener="colorPaletteBtnTest2">
<ui5-color-palette-item value="pink"></ui5-color-palette-item>
<ui5-color-palette-item value="darkblue"></ui5-color-palette-item>
<ui5-color-palette-item value="#444444"></ui5-color-palette-item>
Expand All @@ -48,7 +48,7 @@

<ui5-title level="H5">Test case 3 - Arrow Down to select displayed color</ui5-title>
<ui5-button id="colorPaletteBtnTest3">Open</ui5-button>
<ui5-color-palette-popover id="colorPalettePopoverTest3" show-recent-colors show-more-colors show-default-color default-color="green">
<ui5-color-palette-popover id="colorPalettePopoverTest3" show-recent-colors show-more-colors show-default-color default-color="green" opener="colorPaletteBtnTest3">
<ui5-color-palette-item value="pink"></ui5-color-palette-item>
<ui5-color-palette-item value="darkblue"></ui5-color-palette-item>
<ui5-color-palette-item value="#444444"></ui5-color-palette-item>
Expand All @@ -66,7 +66,7 @@

<ui5-title level="H5">Test case 4 - Arrow Up focuses MoreColors button</ui5-title>
<ui5-button id="colorPaletteBtnTest4">Open</ui5-button>
<ui5-color-palette-popover id="colorPalettePopoverTest4" show-recent-colors show-more-colors show-default-color default-color="green">
<ui5-color-palette-popover id="colorPalettePopoverTest4" show-recent-colors show-more-colors show-default-color default-color="green" opener="colorPaletteBtnTest4">
<ui5-color-palette-item value="pink"></ui5-color-palette-item>
<ui5-color-palette-item value="darkblue"></ui5-color-palette-item>
<ui5-color-palette-item value="#444444"></ui5-color-palette-item>
Expand All @@ -83,7 +83,7 @@

<ui5-title level="H5">Test case 5 - Tests navigation with recent colors</ui5-title>
<ui5-button id="colorPaletteBtnTest5">Open</ui5-button>
<ui5-color-palette-popover id="colorPalettePopoverTest5" show-recent-colors show-more-colors show-default-color default-color="green">
<ui5-color-palette-popover id="colorPalettePopoverTest5" show-recent-colors show-more-colors show-default-color default-color="green" opener="colorPaletteBtnTest5">
<ui5-color-palette-item value="pink"></ui5-color-palette-item>
<ui5-color-palette-item value="darkblue"></ui5-color-palette-item>
<ui5-color-palette-item value="#444444"></ui5-color-palette-item>
Expand All @@ -102,7 +102,7 @@
<ui5-button id="colorPaletteBtnTest6">Open</ui5-button>
<ui5-input id="inpOpenChangeCounter" placeholder="'close' event count"></ui5-input>
<ui5-button id="btnFocusOut">Press</ui5-button>
<ui5-color-palette-popover id="colorPalettePopoverTest6" show-recent-colors show-more-colors show-default-color default-color="green">
<ui5-color-palette-popover id="colorPalettePopoverTest6" show-recent-colors show-more-colors show-default-color default-color="green" opener="colorPaletteBtnTest6">
<ui5-color-palette-item value="pink"></ui5-color-palette-item>
<ui5-color-palette-item value="darkblue"></ui5-color-palette-item>
<ui5-color-palette-item value="#444444"></ui5-color-palette-item>
Expand Down Expand Up @@ -205,27 +205,27 @@

// Tests - default color btn should be on focus after open
colorPaletteBtnTest.addEventListener("click", function(event) {
colorPalettePopoverTest.showAt(this);
colorPalettePopoverTest.open = !colorPalettePopoverTest.open;
});

colorPaletteBtnTest2.addEventListener("click", function(event) {
colorPalettePopoverTest2.showAt(this)
colorPalettePopoverTest2.open = !colorPalettePopoverTest2.open;
});

colorPaletteBtnTest3.addEventListener("click", function(event) {
colorPalettePopoverTest3.showAt(this);
colorPalettePopoverTest3.open = !colorPalettePopoverTest3.open;
});

colorPaletteBtnTest4.addEventListener("click", function(event) {
colorPalettePopoverTest4.showAt(this);
colorPalettePopoverTest4.open = !colorPalettePopoverTest4.open;
});

colorPaletteBtnTest5.addEventListener("click", function(event) {
colorPalettePopoverTest5.showAt(this);
colorPalettePopoverTest5.open = !colorPalettePopoverTest5.open;
});

colorPaletteBtnTest6.addEventListener("click", function(event) {
colorPalettePopoverTest6.showAt(this);
colorPalettePopoverTest6.open = !colorPalettePopoverTest6.open;
});

let openChangeCounter = 0;
Expand Down

0 comments on commit 7ad0cec

Please sign in to comment.