was [always] called with [exactly]: console.warn an error on the firs…

…t invocation
unexpectedjs · Jan 19, 2019 · 8d6493a · 8d6493a
1 parent 550b961
commit 8d6493a
Show file tree

Hide file tree

Showing 2 changed files with 27 additions and 0 deletions.
diff --git a/lib/unexpected-sinon.js b/lib/unexpected-sinon.js
@@ -1072,9 +1072,16 @@
         }
       );
 
+      var deprecationWarningDisplayed = false;
       expect.addAssertion(
         '<spy> was [always] called with [exactly] <any*>',
         function(expect, subject) {
+          if (!deprecationWarningDisplayed) {
+            console.warn(
+              "unexpected-sinon: The 'was [always] called with [exactly]' assertion is deprecated"
+            );
+            deprecationWarningDisplayed = true;
+          }
           expect.errorMode = 'defaultOrNested';
           var args;
           if (expect.flags.exactly) {

diff --git a/test/unexpected-sinon.spec.js b/test/unexpected-sinon.spec.js
@@ -442,6 +442,26 @@ describe('unexpected-sinon', function() {
   });
 
   describe('was called with', function() {
+    beforeEach(function() {
+      sinon.spy(console, 'warn');
+    });
+
+    afterEach(function() {
+      console.warn.restore();
+    });
+
+    it('only renders the warning once when the assertion is called the first time', function() {
+      spy(123);
+      expect(spy, 'was called with', 123);
+      expect(console.warn, 'to have calls satisfying', function() {
+        console.warn(
+          "unexpected-sinon: The 'was [always] called with [exactly]' assertion is deprecated"
+        );
+      });
+      expect(spy, 'was called with', 123);
+      expect(console.warn, 'was called once');
+    });
+
     it('passes if the spy was called with the provided arguments', function() {
       spy('something else');
       spy({ foo: 'bar' }, 'baz', true, false);