Fold the eslint setup for the documentation into the main .eslintrc

Made possible by eslint 7.0.0 because of eslint/eslint#12677
unexpectedjs · May 9, 2020 · c30434e · c30434e
1 parent a0538b0
commit c30434e
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 16 deletions.
diff --git a/.eslintrc b/.eslintrc
@@ -20,5 +20,21 @@
     "mocha/no-exclusive-tests": "error",
     "mocha/no-nested-tests": "error",
     "mocha/no-identical-title": "error"
-  }
+  },
+  "overrides": [
+    {
+      "files": ["documentation/**/*.md"],
+      "plugins": ["markdown"],
+      "rules": {
+        // Some snippets reference variables from previous ones
+        // but eslint-plugin-markdown lints them independently.
+        // Disable the rules that this causes trouble with:
+        "no-unused-vars": 0,
+        "no-undef": 0
+      },
+      "parserOptions": {
+        "sourceType": "script" // Otherwise globalReturn won't work, we use that for the async snippets
+      }
+    }
+  ]
 }
diff --git a/documentation/.eslintrc.js b/documentation/.eslintrc.js
diff --git a/package.json b/package.json
@@ -16,7 +16,7 @@
   "scripts": {
     "prepare": "make build/lib",
     "test": "make test && make test-chrome-headless",
-    "lint": "eslint . && eslint --ext md documentation && prettier --check '**/*.{js,md}'",
+    "lint": "eslint . && prettier --check '**/*.{js,md}'",
     "generate-site": "generate-site --require ./bootstrap-unexpected-markdown.js",
     "update-examples": "generate-site --require ./bootstrap-unexpected-markdown.js --update-examples",
     "version": "(test -n \"${IS_MAKE_RELEASE}\" || (echo Please run make release instead && exit 1)) && offline-github-changelog --next=${npm_package_version} > CHANGELOG.md && git add CHANGELOG.md"