Always escape special characters in string diffs #850
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into a failing build where a diff of strings containing ansi codes was less than helpful: https://github.com/unexpectedjs/magicpen-prism/runs/5255055332?check_suite_focus=true
I took a look, and it seems like we just don't propagate the
markUpSpecialCharacters
flag in some cases. I think this is a bug.Before
After
Here's a slightly simplified case that illustrates it:
Before
After