Update to Chromium 125.0.6422.60 #2852
Conversation
|
on portable linux, linking fails at the end of the build (and I don't know how to fix this): `[60241/60241] LINK ./chrome
ld.lld: error: undefined symbol: data_controls::RulesService::BlockScreenshots(GURL const&) const
|
|
The same link error occured on windows. I updated the windows safebrowsing patch which fixed the error: |
|
since linux and windows is affected, shouldn't this code snipped go to |
|
Yes, thanks! I've updated the PR with that fix along with one for #2659 |
|
portable linux builds and links fine now, result runs on manjaro and ubuntu 20.04/24.04 |
Ahrotahn
changed the title
|
FYI, from the blog post:
|
|
also 125.0.6422.60 builds and runs fine for portable linux |
|
will merge this in a bit, given the severity of the fixes and positive signals from platform maintainers |
|
I encountered this error: [199/199] LINK gn
+ ./out/Default/gn gen out/Default --fail-on-unused-args
ERROR at //chrome/browser/extensions/BUILD.gn:751:34: Label not in deps.
allow_circular_includes_from = [
^
The label "//chrome/browser/safe_browsing:safe_browsing"
was not in the deps of this target. allow_circular_includes_from only allows
targets present in the deps.
See //chrome/browser/extensions/BUILD.gn:24:1: whence it was called.
static_library("extensions") {
^-----------------------------
See //chrome/test/BUILD.gn:612:9: which caused the file to be included.
"//chrome/browser/extensions:test_support",
^-----------------------------------------when building for macOS, might be Ninja 1.12 again, any idea for how to fix it? Didn't find any info related to this one in recent PRs... |
Never mind, I fixed it 🫡 |
What was the problem? Perhaps it might help someone later. |
It is a macOS platform-specific issue, so I didn't say too much. But in a nutshell:
I just added a new patch removing the dependency to fix it. |
|
However, another issue is there: ungoogled-software/ungoogled-chromium-macos#168 (comment) And still have no clue on how to fix it... |
|
@Cubik65536 See if this change helps: --- a/chrome/browser/net/profile_network_context_service.cc
+++ b/chrome/browser/net/profile_network_context_service.cc
@@ -285,20 +285,7 @@
std::unique_ptr<net::ClientCertStore> GetWrappedCertStore(
Profile* profile,
std::unique_ptr<net::ClientCertStore> platform_store) {
- if (!profile || !client_certificates::features::
- IsManagedClientCertificateForUserEnabled()) {
- return platform_store;
- }
-
- auto* provisioning_service =
- client_certificates::CertificateProvisioningServiceFactory::GetForProfile(
- profile);
- if (!provisioning_service) {
- return platform_store;
- }
-
- return client_certificates::ClientCertificatesService::Create(
- provisioning_service, std::move(platform_store));
+ return nullptr;
}
#endif // BUILDFLAG(IS_WIN) || BUILDFLAG(IS_MAC)
If that works then its something that we should add to the core repo since it affects more than one platform now. |
|
Should work for windows as well 👍 |
This PR updates to Chromium 125.0.6422.60
Notes:
There was a removal in block-trk-and-subdomains.patch for [5385633]
The safebrowsing patch has new additions for [5427621], [5367497], and [5381220]. There's also a removal for a previous change that was reverted in [5411050]
remove-unused-preferences-fields.patch had changes for [5435195], [5432217], and [5446984]; and new additions for [5372487], [5390129], [5383467], and [5439493]
The QR generator has been removed from the location bar in [5445358]
browsing_data features have been removed from about_flags in [5385333], so the clear-data-on-exit patch has been updated to place the flag in browser_features instead
The disable-capture-all-screens patch had some changes for [5370579] and [5398120]
Change log
Blog post