Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add imagemagick to run.yaml #38

Open
wants to merge 1 commit into
base: staging
Choose a base branch
from
Open

Conversation

kallui
Copy link

@kallui kallui commented Sep 24, 2023

Added imagemagic app to elf-loader, and tested that its working

@razvand
Copy link
Contributor

razvand commented Sep 25, 2023

@kallui , you need to add a proper command, something that works, that does something. Update the command key accordingly. See the sample command used for nginx.

@razvand razvand self-requested a review September 25, 2023 00:23
@razvand razvand self-assigned this Sep 25, 2023
Signed-off-by: Nicholas Januar <nicho.januar@gmail.com>
@kallui
Copy link
Author

kallui commented Sep 25, 2023

@razvand Updated. thank you

@razvand razvand added the enhancement New feature or request label Sep 25, 2023
Copy link
Contributor

@razvand razvand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-by: Razvan Deaconescu razvand@unikraft.io
Approved-by: Razvan Deaconescu razvand@unikraft.io

@razvand
Copy link
Contributor

razvand commented Sep 25, 2023

20 HP

@razvand razvand changed the base branch from stable to staging October 18, 2023 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants