Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib/ukzeropage: Introduce zeropage library #1384

Open
wants to merge 1 commit into
base: staging
Choose a base branch
from

Conversation

andreittr
Copy link
Contributor

Description of changes

This change introduces ukzeropage, a library providing a singleton instance of read-only page filled with zero bytes. This page exists independent of virtual memory support.

Prerequisite checklist

  • Read the contribution guidelines regarding submitting new changes to the project;
  • Tested your changes against relevant architectures and platforms;
  • Ran the checkpatch.uk on your commit series before opening this PR;
  • Updated relevant documentation.

Base target

  • Architecture(s): [e.g. x86_64 or N/A]
  • Platform(s): [e.g. kvm, xen or N/A]
  • Application(s): [e.g. app-python3 or N/A]

Additional configuration

N/A

This change introduces ukzeropage, a library providing a singleton
instance of read-only page filled with zero bytes.
This page exists independent of virtual memory support.

Signed-off-by: Andrei Tatar <andrei@unikraft.io>
@andreittr andreittr requested review from a team as code owners April 16, 2024 13:45
@github-actions github-actions bot added area/lib Internal Unikraft Microlibrary lang/c Issues or PRs to do with C/C++ labels Apr 16, 2024
@nderjung nderjung added new/library This PR or Issue intends to add a new library to Unikraft release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Apr 16, 2024
@razvand razvand requested review from mogasergiu, eduardvintila and adinamariav and removed request for a team April 28, 2024 05:38
@razvand razvand added this to the v0.17.0 (Calypso) milestone Apr 28, 2024
Copy link
Member

@eduardvintila eduardvintila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good.

Reviewed-by: Eduard Vintilă eduard.vintila47@gmail.com

@mogasergiu
Copy link
Member

Is there a specific use-case for this addition as of now? I understand this is part of more work to come, but I would like to wait and see how that makes use of this before merging this. Therefore, I propose we move this PR to 0.18.

@andreittr
Copy link
Contributor Author

Is there a specific use-case for this addition as of now? I understand this is part of more work to come, but I would like to wait and see how that makes use of this before merging this. Therefore, I propose we move this PR to 0.18.

In addition to work in progress (that is not targeted for 0.17), this change is intended to be used together with #1226 and #1411 to provide sendfile support for zerofiles (sendfile is blocked pending the above 2 PRs). Depending on whether we want ukfile sendfile support in 0.17 or not we can decide to postpone this.

@mogasergiu
Copy link
Member

Ah I see. Yep, I would rather we reviewed that first to see how this is actually used before merging something unused.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/lib Internal Unikraft Microlibrary lang/c Issues or PRs to do with C/C++ new/library This PR or Issue intends to add a new library to Unikraft release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
Status: 🏗 In Progress
Development

Successfully merging this pull request may close these issues.

None yet

5 participants