Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib/ukfile: Remove padding from struct uk_statx #1387

Open
wants to merge 1 commit into
base: staging
Choose a base branch
from

Conversation

andreittr
Copy link
Contributor

Description of changes

This change removes the padding fields from uk_statx, minimizing memory waste when allocating inside the kernel.
Syscalls never reveal these kernel structs, and userspace allocates a struct statx dictated by its libc.

Prerequisite checklist

  • Read the contribution guidelines regarding submitting new changes to the project;
  • Tested your changes against relevant architectures and platforms;
  • Ran the checkpatch.uk on your commit series before opening this PR;
  • Updated relevant documentation.

Base target

  • Architecture(s): [e.g. x86_64 or N/A]
  • Platform(s): [e.g. kvm, xen or N/A]
  • Application(s): [e.g. app-python3 or N/A]

Additional configuration

N/A

This change removes the padding fields from uk_statx, minimizing memory
waste when allocating inside the kernel.
Syscalls never reveal these kernel structs, and userspace allocates a
struct statx dictated by its libc.

Signed-off-by: Andrei Tatar <andrei@unikraft.io>
@andreittr andreittr requested a review from a team as a code owner April 17, 2024 17:57
@github-actions github-actions bot added the area/lib Internal Unikraft Microlibrary label Apr 17, 2024
@andreittr andreittr added this to the v0.17.0 (Calypso) milestone Apr 30, 2024
@razvand razvand requested review from Mihnea27, andreistan26 and StefanJum and removed request for a team May 21, 2024 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/lib Internal Unikraft Microlibrary
Projects
Status: 🏗 In Progress
Development

Successfully merging this pull request may close these issues.

None yet

2 participants