Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support: Change PYTHONCMD to python3 #1391

Open
wants to merge 1 commit into
base: staging
Choose a base branch
from

Conversation

tbunch1
Copy link

@tbunch1 tbunch1 commented Apr 23, 2024

Make it so that python3 is used to run scripts.

Prerequisite checklist

  • Read the contribution guidelines regarding submitting new changes to the project;
  • Tested your changes against relevant architectures and platforms;
  • Ran the checkpatch.uk on your commit series before opening this PR;
  • Updated relevant documentation.

Base target

  • Architecture(s): [N/A]
  • Platform(s): [N/A]
  • Application(s): [N/A]

Additional configuration

None.

Description of changes

Change makefile.patch so that python3 is used to run Python scripts.
From what we could tell all other instances of python have been replaced by python3.

GitHub-Fixes: #1006

@tbunch1 tbunch1 requested a review from a team as a code owner April 23, 2024 23:33
@github-actions github-actions bot added the area/support Support scripts, tools, services. label Apr 23, 2024
@nderjung
Copy link
Member

nderjung commented Apr 24, 2024

Hi @tbunch1! Thanks for the contribution!

If you are co-authoring commits with peers, please include their sign-off as part of the commit message. Thanks!

@razvand razvand requested review from StefanJum and mariasfiraiala and removed request for a team April 28, 2024 05:33
@razvand razvand added this to the v0.17.0 (Calypso) milestone Apr 28, 2024
Copy link
Contributor

@mariasfiraiala mariasfiraiala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution @tbunch1! The changes look fine, however I have some comments regarding the commit message.

  1. As @nderjung mentioned, you need to add the Co-authored-by tag inside the commit message. You have edited the PR message, not the commit message, so please do that.

  2. Add a valid email to the Signed-off-by tag; <92049355+tbunch1@users.noreply.github.com> is automatically generated by GitHub so it doesn't reflect your real details (and it looks kinda bad).

That's all on my part, thanks!

Make it so that python3 is used to run scripts.

Co-authored-by: Eddie Cazares <ecazares15@utexas.edu>
Co-authored-by: Lindsey Bowen  <lindseyb803@gmail.com>
Signed-off-by: Thomas Bunch  <tebunch@utexas.edu>
Copy link
Member

@StefanJum StefanJum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi. The changes look good, but you all need to add a signed-off-by tag to the commit message.

@nderjung nderjung changed the title support/makefile.patch: Change PYTHONCMD to python3 support: Change PYTHONCMD to python3 May 17, 2024
Copy link
Member

@nderjung nderjung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, I think the multiple Co-authored-by is enough with at least 1 Signed-off-by by the committer. This PR is good to go imho. Thanks!

Reviewed-by: Alexander Jung alex@unikraft.io

@razvand razvand assigned razvand and unassigned skuenzer May 21, 2024
Copy link
Contributor

@mariasfiraiala mariasfiraiala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

Reviewed-by: Maria Sfiraiala maria.sfiraiala@gmail.com

Copy link
Member

@StefanJum StefanJum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-by: Stefan Jumarea stefanjumarea02@gmail.com

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/support Support scripts, tools, services.
Projects
Status: 🏗 In Progress
Development

Successfully merging this pull request may close these issues.

Replace instances of python with python3 and ensure script integrity
6 participants