lib/posix-*: Fix missing/unneeded dependencies #1393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds a Kconfig dependency to ukatomic on several libraries that were written before the ukatomic split-off. This makes their using atomic operations explicit. Signed-off-by: Andrei Tatar <andrei@unikraft.io>
This change removes the Kconfig dependency on LIBUKLOCK as well as inclusion of <uk/mutex.h> as these were not used. Signed-off-by: Andrei Tatar <andrei@unikraft.io>
This change adds a conditional dependency on (no)libc, required because ukfile uses many libc-provided types. Signed-off-by: Andrei Tatar <andrei@unikraft.io>
github-actions
bot
added
area/lib
rares-miculescu
approved these changes
Apr 28, 2024
There was a problem hiding this comment.
Looks good on my side.
Reviewed-by: Rares Miculescu miculescur@gmail.com
robertZamfir601
approved these changes
May 1, 2024
There was a problem hiding this comment.
Looks good to me
Reviewed-by: Robert Zamfir georobi.016@gmail.com
razvand
approved these changes
May 21, 2024
razvand
pushed a commit
that referenced
this pull request
May 21, 2024
This change adds a Kconfig dependency to ukatomic on several libraries that were written before the ukatomic split-off. This makes their using atomic operations explicit. Signed-off-by: Andrei Tatar <andrei@unikraft.io> Reviewed-by: Robert Zamfir <georobi.016@gmail.com> Approved-by: Razvan Deaconescu <razvand@unikraft.io> GitHub-Closes: #1393
razvand
pushed a commit
that referenced
this pull request
May 21, 2024
This change removes the Kconfig dependency on LIBUKLOCK as well as inclusion of <uk/mutex.h> as these were not used. Signed-off-by: Andrei Tatar <andrei@unikraft.io> Reviewed-by: Robert Zamfir <georobi.016@gmail.com> Approved-by: Razvan Deaconescu <razvand@unikraft.io> GitHub-Closes: #1393
razvand
pushed a commit
that referenced
this pull request
May 21, 2024
This change adds a conditional dependency on (no)libc, required because ukfile uses many libc-provided types. Signed-off-by: Andrei Tatar <andrei@unikraft.io> Reviewed-by: Robert Zamfir <georobi.016@gmail.com> Approved-by: Razvan Deaconescu <razvand@unikraft.io> GitHub-Closes: #1393
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This changeset fixes a number of missing or unneeded Kconfig dependencies. See individual commits for details.
Prerequisite checklist
checkpatch.ukon your commit series before opening this PR;Base target
x86_64or N/A]kvm,xenor N/A]app-python3or N/A]Additional configuration
N/A