Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib/posix-fdio: Add bincompat support for RWF_* #1394

Open
wants to merge 1 commit into
base: staging
Choose a base branch
from

Conversation

andreittr
Copy link
Contributor

Description of changes

This change adds values for RWF_* flags in posix-fdio, allowing it to interpret their meaning even without support from our (no)libc. This enhances binary compatibility.

Prerequisite checklist

  • Read the contribution guidelines regarding submitting new changes to the project;
  • Tested your changes against relevant architectures and platforms;
  • Ran the checkpatch.uk on your commit series before opening this PR;
  • Updated relevant documentation.

Base target

  • Architecture(s): [e.g. x86_64 or N/A]
  • Platform(s): [e.g. kvm, xen or N/A]
  • Application(s): [e.g. app-python3 or N/A]

Additional configuration

N/A

This change adds values for RWF_* flags in posix-fdio, allowing it to
interpret their meaning even without support from our (no)libc.
This enhances binary compatibility.

Signed-off-by: Andrei Tatar <andrei@unikraft.io>
@andreittr andreittr requested a review from a team as a code owner April 24, 2024 10:34
@github-actions github-actions bot added area/lib Internal Unikraft Microlibrary lang/c Issues or PRs to do with C/C++ labels Apr 24, 2024
@razvand razvand requested review from robertZamfir601 and Mihnea0Firoiu and removed request for a team April 28, 2024 05:30
@razvand razvand self-assigned this Apr 28, 2024
@razvand razvand added this to the v0.17.0 (Calypso) milestone May 21, 2024
Copy link
Member

@Mihnea0Firoiu Mihnea0Firoiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good.
Reviewed-by: Mihnea Firoiu mihneafiroiu0@gmail.com

@robertZamfir601
Copy link

Hello! The PR looks good, the functions are a lot clearer this way. I have two questions/observations though:

  1. For RWF_NOWAIT, previously the flag was ignored, but the user could still read. Now we will return an error that might break some apps that worked previously. Could this be a problem?
  2. Should we use uk_pr_warn_once for RWF_SYNC, RWF_DYNC and RWF_APPEND also?

Everything else looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/lib Internal Unikraft Microlibrary lang/c Issues or PRs to do with C/C++
Projects
Status: 🏗 In Progress
Development

Successfully merging this pull request may close these issues.

None yet

4 participants