plat/kvm/x86: Add dependency to ukbitops #1395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds a Kconfig dependency on ukbitops to the x86 KVM platform code, as it is needed by tscclock.c. Signed-off-by: Andrei Tatar <andrei@unikraft.io>
razvand
requested review from
Mihnea27,
SerbanSo and
eduardvintila
and removed request for
a team
razvand
requested review from
rares-miculescu
and removed request for
SerbanSo and
eduardvintila
rares-miculescu
approved these changes
Apr 28, 2024
There was a problem hiding this comment.
Looks good on my side.
Reviewed-by: Rares Miculescu miculescur@gmail.com
Mihnea27
approved these changes
Apr 28, 2024
There was a problem hiding this comment.
Looks good!
Reviewed by: Mihnea Popeanga popeanga.mihnea@gmail.com
razvand
approved these changes
May 21, 2024
razvand
pushed a commit
that referenced
this pull request
May 21, 2024
This change adds a Kconfig dependency on ukbitops to the x86 KVM platform code, as it is needed by tscclock.c. Signed-off-by: Andrei Tatar <andrei@unikraft.io> Reviewed-by: Rares Miculescu <miculescur@gmail.com> Approved-by: Razvan Deaconescu <razvand@unikraft.io> GitHub-Closes: #1395
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This change adds a Kconfig dependency on ukbitops to the x86 KVM platform code, as it is needed by tscclock.c.
Prerequisite checklist
checkpatch.ukon your commit series before opening this PR;Base target
x86_64or N/A]kvm,xenor N/A]app-python3or N/A]Additional configuration
N/A