Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib/ukfile: API improvements #1397

Merged
merged 3 commits into from May 15, 2024
Merged

lib/ukfile: API improvements #1397

merged 3 commits into from May 15, 2024

Conversation

andreittr
Copy link
Contributor

Description of changes

This changeset brings several improvements to the ukfile API:

  • convenience file destructor for static files that prints a warning and does nothing
  • expose I/O locking & event update operations on file state objects, in addition to files themselves; this is a stabilization of the API and a commitment to handle these aspects as part of file state going forward.

May benefit the following PR (if merged before this, will append patches here):

Prerequisite checklist

  • Read the contribution guidelines regarding submitting new changes to the project;
  • Tested your changes against relevant architectures and platforms;
  • Ran the checkpatch.uk on your commit series before opening this PR;
  • Updated relevant documentation.

Base target

  • Architecture(s): [e.g. x86_64 or N/A]
  • Platform(s): [e.g. kvm, xen or N/A]
  • Application(s): [e.g. app-python3 or N/A]

Additional configuration

N/A

@andreittr
lib/ukfile: Add static destructor to file nops
67f3123 
This change adds a destructor for statically allocated files that prints
a warning and exits.

Signed-off-by: Andrei Tatar <andrei@unikraft.io>
@andreittr
lib/ukfile: Expose locking on file state objects
8652a5b 
This change adds functions to the ukfile API that perform I/O locking
directly on file state instances, in addition to files as before.

Signed-off-by: Andrei Tatar <andrei@unikraft.io>
@andreittr
lib/ukfile: Expose events on file state objects
734a563 
This change adds functions to the ukfile API that perform event updates
directly on file state instances, in addition to files as before.

Signed-off-by: Andrei Tatar <andrei@unikraft.io>
@andreittr andreittr requested a review from a team as a code owner April 24, 2024 11:42
@github-actions github-actions bot added area/lib Internal Unikraft Microlibrary lang/c Issues or PRs to do with C/C++ labels Apr 24, 2024
@razvand razvand requested review from Mihnea27 and SerbanSo and removed request for a team April 28, 2024 05:26
@razvand razvand added this to the v0.17.0 (Calypso) milestone Apr 28, 2024
Mihnea27
Mihnea27 approved these changes Apr 30, 2024
View reviewed changes
Copy link

@Mihnea27 Mihnea27 left a comment •
edited by razvand

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Reviewed-by: Mihnea Popeanga popeanga.mihnea@gmail.com

SerbanSo
SerbanSo approved these changes May 7, 2024
View reviewed changes
Copy link

@SerbanSo SerbanSo left a comment •
edited by razvand

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Reviewed-by: Serban Sorohan serban.sorohan@gmail.com

mschlumpp
mschlumpp approved these changes May 10, 2024
View reviewed changes
Copy link
Member

@mschlumpp mschlumpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved-by: Marco Schlumpp marco@unikraft.io

@razvand razvand changed the base branch from staging to staging-1397 May 15, 2024 07:45
@razvand razvand merged commit beae5b1 into unikraft:staging-1397 May 15, 2024
14 checks passed
razvand pushed a commit that referenced this pull request May 15, 2024
@andreittr @razvand
lib/ukfile: Add static destructor to file nops
7826dd4 
This change adds a destructor for statically allocated files that prints
a warning and exits.

Signed-off-by: Andrei Tatar <andrei@unikraft.io>
Reviewed-by: Mihnea Popeanga <popeanga.mihnea@gmail.com>
Reviewed-by: Serban Sorohan <serban.sorohan@gmail.com>
Approved-by: Marco Schlumpp <marco@unikraft.io>
GitHub-Closes: #1397
razvand pushed a commit that referenced this pull request May 15, 2024
@andreittr @razvand
lib/ukfile: Expose locking on file state objects
8c6e63d 
This change adds functions to the ukfile API that perform I/O locking
directly on file state instances, in addition to files as before.

Signed-off-by: Andrei Tatar <andrei@unikraft.io>
Reviewed-by: Mihnea Popeanga <popeanga.mihnea@gmail.com>
Reviewed-by: Serban Sorohan <serban.sorohan@gmail.com>
Approved-by: Marco Schlumpp <marco@unikraft.io>
GitHub-Closes: #1397
razvand pushed a commit that referenced this pull request May 15, 2024
@andreittr @razvand
lib/ukfile: Expose events on file state objects
6a7838c 
This change adds functions to the ukfile API that perform event updates
directly on file state instances, in addition to files as before.

Signed-off-by: Andrei Tatar <andrei@unikraft.io>
Reviewed-by: Mihnea Popeanga <popeanga.mihnea@gmail.com>
Reviewed-by: Serban Sorohan <serban.sorohan@gmail.com>
Approved-by: Marco Schlumpp <marco@unikraft.io>
GitHub-Closes: #1397
@andreittr andreittr mentioned this pull request May 15, 2024
Open
4 tasks
@andreittr andreittr deleted the ttr/ukfile-apiboost branch May 24, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mschlumpp mschlumpp mschlumpp approved these changes

@Mihnea27 Mihnea27 Mihnea27 approved these changes

@SerbanSo SerbanSo SerbanSo approved these changes

Assignees

@mschlumpp mschlumpp

Labels
area/lib Internal Unikraft Microlibrary lang/c Issues or PRs to do with C/C++
Projects
Unikraft Core Roadmap
Status: ✅ Done!
Milestone
v0.17.0 (Calypso)
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@andreittr @mschlumpp @Mihnea27 @SerbanSo @razvand