lib/vfscore: Fix warnings in automount.c #1398
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- remove const from path in vfscore_mount_volume - use the device name for the message in uk_list_for_each_entry_reverse Signed-off-by: Radu Coriu <radu.gabrielc@gmail.com>
github-actions
bot
added
area/lib
skuenzer
reviewed
Apr 29, 2024
| @@ -625,7 +628,7 @@ static int vfscore_ukopt_mkmp(char *path) | |||
| */ | |||
| static inline int vfscore_mount_volume(const struct vfscore_volume *vv) | |||
| { | |||
| const char *path; | |||
| char *path; | |||
There was a problem hiding this comment.
What is the issue with const here? The path was treated as const on purpose because struct vfscore_volume is handed over as const as well so that we can support a const compiled-in filesystem table.
There was a problem hiding this comment.
The path string is actually modified in vfscore_ukopt_mkmp at line 686. I initially wanted to strdup vv->path because of that constness promise in the input param, but after talking to @StefanJum we decided to only remove const.
Now I see that vv->path is also used at line 693 in vfscore_extract_volume, so don't know if a strdup would actually be ok and how the LIBVFSCORE_UKOPT_MKMP flag should interact with CONFIG_LIBUKCPIO
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisite checklist
checkpatch.ukon your commit series before opening this PR;Base target
Additional configuration
Description of changes