Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib/ukboot: Fix unused variable warning in boot.c #1399

Closed
wants to merge 1 commit into from

Conversation

keenox
Copy link

@keenox keenox commented Apr 28, 2024

Added CONFIG_LIBUKDEBUG_PRINTK_INFO check for envp declaration

Prerequisite checklist

  • Read the contribution guidelines regarding submitting new changes to the project;
  • Tested your changes against relevant architectures and platforms;
  • Ran the checkpatch.uk on your commit series before opening this PR;
  • Updated relevant documentation.

Base target

  • Application(s): nginx 1.25

Additional configuration

Description of changes

Added CONFIG_LIBUKDEBUG_PRINTK_INFO check for envp declaration

Signed-off-by: Radu Coriu <radu.gabrielc@gmail.com>
@keenox keenox requested a review from a team as a code owner April 28, 2024 11:42
@github-actions github-actions bot added area/lib Internal Unikraft Microlibrary lang/c Issues or PRs to do with C/C++ lib/ukboot labels Apr 28, 2024
@razvand razvand requested review from Alex-deVis, adinamariav and Mihnea0Firoiu and removed request for a team May 5, 2024 08:03
@razvand razvand added the kind/build-warning Issue or PR is related with a build warning label May 5, 2024
@razvand razvand added this to the v0.17.0 (Calypso) milestone May 5, 2024
Copy link
Member

@Mihnea0Firoiu Mihnea0Firoiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
Reviewed-by: Mihnea Firoiu mihneafiroiu0@gmail.com

@michpappas
Copy link
Member

Looks like a duplicate of #1378

@StefanJum
Copy link
Member

Duplicate of #1378

@StefanJum StefanJum marked this as a duplicate of #1378 May 18, 2024
@StefanJum StefanJum closed this May 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/lib Internal Unikraft Microlibrary kind/build-warning Issue or PR is related with a build warning lang/c Issues or PRs to do with C/C++ lib/ukboot
Projects
Status: Done!
Development

Successfully merging this pull request may close these issues.

None yet

5 participants