New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lib/uktest: Introduce FIX ME
assertion in uktest
#1401
base: staging
Are you sure you want to change the base?
Conversation
Hey team! As mentioned in #1027 , I've made some initial changes in order to support the These are just some initial changes, please feel free to leave any feedback before I add support for more tests. Thanks! |
FIX ME
assertion in uktest
FIX ME
assertion in uktest
Hey all, I've gone ahead and integrated the rest of appropriate FIX ME downgrades for tests. Please feel free to leave any more feedback! |
Signed-off-by: syuan <syuan@node0.syuan-204435.wisr-pg0.utah.cloudlab.us> lib/uktest: formatting changes Signed-off-by: syuan <syuan@node0.syuan-204435.wisr-pg0.utah.cloudlab.us> lib/uktest: formatting changes Signed-off-by: syuan <syuan@node0.syuan-204435.wisr-pg0.utah.cloudlab.us> lib/uktest: add rest of tests Signed-off-by: syuan <syuan@node0.syuan-206086.wisr-pg0.utah.cloudlab.us> lib/uktest: style changes Signed-off-by: syuan <syuan@node0.syuan-206086.wisr-pg0.utah.cloudlab.us> lib/uktest: style changes Signed-off-by: syuan <syuan@node0.syuan-206086.wisr-pg0.utah.cloudlab.us> Adds FIX ME test downgrade to uktest testing suite lib/uktest: style changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much for tackling this and apologies for the delay in getting back to you!
On my side I still need to test this properly and will get back to you soon with the status of my tests.
I have one inline comment, but additionally, the FIXME macro should be ansi-coloured into yellow (similar to pass/fail).
@@ -29,4 +29,8 @@ config LIBUKTEST_TEST_MYSELF | |||
bool "Run self-test to check sanity" | |||
default n | |||
|
|||
config LIBUKTEST_STRICT_MODE | |||
bool "Count failing FIX_ME tests" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To keep things consistent internally, lets ensure FIXME
is a single word, i.e.:
- bool "Count failing FIX_ME tests"
+ bool "Count failing FIXME tests"
Please ensure all other instances of "FIX ME" and "FIX_ME" (including commits) are adjusted to "FIXME".
I think the only exception should be the visual message displayed in the console log.
@YuanSamuel , could you please update this PR to include the feedback from @nderjung ? |
Prerequisite checklist
checkpatch.uk
on your commit series before opening this PR;Base target
Additional configuration
CONFIG_LIBUKTEST_STRICT_MODE=y
Description of changes
This PR attempts to address #1027 , which introduces a new
FIX ME
assertion to downgrade known failing tests. Tests marked asFIX_ME
will show up asOMITTED
in the testing logs, and will be counted toward the overall failure count only if the strict mode config is turned on.An example output log is below:
GitHub-Closes: #1027