lib/{ukvmem,vfscore}: Move file VMA implementation into vfscore #1407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change moves the definition of file and DMA VMA structs from the public `<uk/vma_types.h>` header and into their respective implementation source files. Signed-off-by: Andrei Tatar <andrei@unikraft.io>
This change moves several definitions from the internal "vmem.h" header into the public ukvmem API. Specifically: - vmem_vma_len -> uk_vma_len; part of uk/vmem.h now - vma_op_* -> uk_vma_op_*; part of new uk/vma_ops.h This allows custom VMA types to be implemented externally from ukvmem using only the public ukvmem API. Checkpatch-Ignore: FUNCTION_WITHOUT_ARGS Signed-off-by: Andrei Tatar <andrei@unikraft.io>
This change moves the implementation of file-backed VMAs from ukvmem to vfscore, freeing the former from an unorthogonal responsibility. Calling code in posix-mmap is updated. Signed-off-by: Andrei Tatar <andrei@unikraft.io>
github-actions
bot
added
area/lib
razvand
requested review from
mogasergiu,
andreistan26 and
razvanvirtan
and removed request for
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This changeset moves the implementation of the file VMA type from
ukvmemtovfscore, bringing file VMAs under the same roof as file operations more generally. The implementation itself is left minimally changed, and no difference to behavior should be observed. Fixing and/or otherwise improving the existing file VMA code falls outside of scope.As prerequisites for its main goal, this PR includes several tweaks to the
ukvmemAPI, making it easier for libs to implement their own custom VMA types.Following this change,
ukvmemremains as before responsible for virtual memory management & the VMA API, but only provides implementations for fundamental VMAs: anonymous, stack, DMA, reserved.Other, custom types of VMAs are to be implemented by their respective libs.
Prerequisite checklist
checkpatch.ukon your commit series before opening this PR;Base target
x86_64or N/A]kvm,xenor N/A]app-python3or N/A]Additional configuration
N/A; behavior and configuration should be unaffected.