Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add known limitation for nested property intersection types #302

Merged
merged 1 commit into from May 30, 2023

Conversation

mmkal
Copy link
Contributor

@mmkal mmkal commented May 29, 2023

See mmkal/expect-type#21 (comment) for (lots of!) context

@changeset-bot
Copy link

changeset-bot bot commented May 29, 2023

⚠️ No Changeset found

Latest commit: fa351af

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@unional
Copy link
Owner

unional commented May 29, 2023

Thanks, that is definitely a limitation. If we do that recursively, it will lead to infinite loop when there are recursive types.

Here, I take the stands that { a: 1 } & { b: 1 } == { a: 1, b: 1 } as in type category they are just two representations of the same category. Thus when doing comparison they should be treated the same.

There can be a IsStrictEqual type that excludes union and intersection check if there are such use case.

@unional unional merged commit 3a5918e into unional:main May 30, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants