Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GitHub Action for publishing new releases #59

Open
wants to merge 12 commits into
base: develop
Choose a base branch
from

Conversation

pverscha
Copy link
Member

This PR adds a new GitHub Action that automatically pushes a new version of this package on NPM, and that automatically creates a new release on GitHub (which we still need to manually annotate with release notes).

@pverscha pverscha requested a review from bmesuere March 12, 2021 08:44
@pverscha pverscha self-assigned this Mar 12, 2021
Copy link
Member

@bmesuere bmesuere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not too fond of automatic publishing "on push". Since this isn't something that is done a lot, a manual trigger using workflow_dispatch might be an alternative.

When triggering manually, it is possible to enter a variable which could be used to pass along a version number. Instead of parsing the number from the file, the action could use the provided version number and save it in the necessary files in the repo (even committing the changed file(s)).

@pverscha
Copy link
Member Author

I updated the action so that it can only be started from a workflow. The new version number will be asked upon invocation of the workflow dispatch and the package.json file will be updated (and committed) with the new changes in this action.

@pverscha pverscha requested a review from bmesuere March 15, 2021 12:05
Copy link
Member

@bmesuere bmesuere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I seem to have forgotten to add my suggestion to github:
I think a lot of the regex stuff can be handled by npm version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants