Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#149 [FEATURE] Create button in variables create events as nested scriptable objects (initial implementation). #316

Open
wants to merge 7 commits into
base: canary
Choose a base branch
from

Conversation

ThimoDEV
Copy link
Collaborator

This PR adds the option to Fuse and Diffuse Atom Events to Atom variables, valueLists, instancers etc. The current implementation is shown in the video's below. NOTE: In the current design its up to the user to configure their project files the way they want. This can lead to possibly unwanted or weird situations, but thats up to the user right now.

Features:

  • Fuse/Diffuse referenced events in the Drawer
  • Create new standard nested Events
  • Nest ScriptableObjects (and other type of project assets) manually by pressing ALT and dragging the asset onto another asset
    in the project view.

Video 1: https://www.youtube.com/watch?v=6KaW-NeFDTg

Video 2: https://user-images.githubusercontent.com/68739517/143941070-8175ed01-6bb7-48f7-a66d-3b5faf18fc7c.mp4

@soraphis
Copy link
Collaborator

soraphis commented Dec 2, 2021

I think if a reference is removed ... the old value should be checked, if it is fused and automatically defuse.

@ThimoDEV
Copy link
Collaborator Author

ThimoDEV commented Dec 2, 2021

I think if a reference is removed ... the old value should be checked, if it is fused and automatically defuse.

Is what you mean the feature that is shown in the first video around 00:35 seconds?

@soraphis
Copy link
Collaborator

soraphis commented Dec 2, 2021

Is what you mean the feature that is shown in the first video around 00:35 seconds?

ahhh. yes indeed (does it also work when overriden?). i had not payed enough attention to it the first time and thought you had clicked defuse. then i saw in the second video the reference staying in there. at about 00:12 when overridden

@ThimoDEV
Copy link
Collaborator Author

ThimoDEV commented Dec 2, 2021

Is what you mean the feature that is shown in the first video around 00:35 seconds?

ahhh. yes indeed (does it also work when overriden?). i had not payed enough attention to it the first time and thought you had clicked defuse. then i saw in the second video the reference staying in there. at about 00:12 when overridden

About your overriden question, I added an option when the user has an Atom fused and drags a new event into the field. The old fused Atom will get diffused and the new reference gets immediately fused. Is this what you mean? An example is shown here: https://youtu.be/wlq2dr1-na0

@miikalo miikalo added this to the v5.0 milestone Dec 28, 2021
@ThimoDEV
Copy link
Collaborator Author

I would like to suggest to target this PR to the V4.4.x release as I've just sent a PR for this feature targeted at V5. V5 required some additional changes to the AtomDrawer file overall.

@soraphis
Copy link
Collaborator

I would like to suggest to target this PR to the V4.4.x release ....

Some time ago it was decided that 4.x won't receive new features but only bug fixes, hence those features target V5

@soraphis soraphis mentioned this pull request Mar 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants