feat(fancy): underlining #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ineshbose
changed the title
|
I love this!! Only regarding special formatting seems a nice idea too but can you please remove it from this PR? I like to think more together about possible edge cases and best syntax not conflicting with actual user texts. |
|
Sure, that's done. Hopefully the special formatting gets brainstormed and added soon - happy to contribute 馃檪 |
ineshbose
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to highlighting backticks, this adds functionality to underline.
Renamed
highlightBacktickstocharacterFormatto chain the formatting. 馃檪Preview (based on
examples/special.ts):Update: added special format syntax as well (really need this feature!)