Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: correctly merge the date key #101

Closed
wants to merge 1 commit into from
Closed

fix: correctly merge the date key #101

wants to merge 1 commit into from

Conversation

171h
Copy link

@171h 171h commented Jul 2, 2023

@171h
Copy link
Author

171h commented Jul 6, 2023

Hi @pi0 , is it possible for this PR to be merged?

@manniL manniL requested a review from pi0 August 17, 2023 13:36
@pi0
Copy link
Member

pi0 commented Oct 24, 2023

Hi dear @171h thanks for making issue and attempt to fix via this PR ❤️

I think it is a valid fix but fix could be slightly different to cover all possible cases ~> #111

@pi0 pi0 closed this Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manniL manniL manniL approved these changes

@pi0 pi0 Awaiting requested review from pi0

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@171h @pi0 @manniL