Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use optional chaining #112

Closed
wants to merge 1 commit into from
Closed

Conversation

ferferga
Copy link

@ferferga ferferga commented Oct 25, 2023

πŸ”— Linked issue

Review comments from #104

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Refer to @pi0 in this comment. I think the optional chaining it's still relevant.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@ferferga ferferga changed the title chore: use optional chaining and simplify conditions chore: use optional chaining Oct 25, 2023
@pi0
Copy link
Member

pi0 commented Nov 8, 2023

Thanks for splitting this part of the change. Can you please remind me why this change was required? Purely for code readability?

@ferferga
Copy link
Author

ferferga commented Nov 8, 2023

@pi0 Yes, exactly.

@pi0
Copy link
Member

pi0 commented Nov 8, 2023

Ah, thanks for confirming. If this is only the case, I think it might be better to keep it as is.

I also really want to get rid of legacy syntaxes and prefer new ones but optional chaining can be particularly tricky to use especially in defu which is used in many many different projects. Many of them use Nuxt 2 with webpack 4 which does not understand this syntax (natively) as it uses older acorn parser even tough all recent browsers support it.

@pi0 pi0 closed this Nov 8, 2023
@pi0 pi0 mentioned this pull request Nov 8, 2023
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants