fix(router): parse url using URL for pathname (#196)

unjs · Oct 15, 2022 · a1f975f · a1f975f
1 parent 4229ce0
commit a1f975f
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 8 deletions.
diff --git a/src/router.ts b/src/router.ts
@@ -51,15 +51,10 @@ export function createRouter (opts: CreateRouterOptions = {}): Router {
 
   // Main handle
   router.handler = eventHandler((event) => {
-    // Match route
-
     // Remove query parameters for matching
-    let path = event.req.url || '/'
-    const queryUrlIndex = path.lastIndexOf('?')
-    if (queryUrlIndex > -1) {
-      path = path.substring(0, queryUrlIndex)
-    }
+    const path = new URL(event.req.url || '/', 'http://localhost').pathname
 
+    // Match route
     const matched = _router.lookup(path)
     if (!matched) {
       if (opts.preemtive) {

diff --git a/test/router.test.ts b/test/router.test.ts
@@ -50,7 +50,7 @@ describe('router', () => {
   })
 
   it('Handle url with query parameters, include "?" in url path', async () => {
-    const res = await request.get('/test/?/a?title=test')
+    const res = await request.get('/test/?/a?title=test&returnTo=/path?foo=bar')
     expect(res.status).toEqual(200)
   })