New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor!: reduce node.js dependency #178
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pi0
changed the title
refactor!: remove compatibility handler support
refactor!: reduce node.js handler support
Sep 16, 2022
pi0
force-pushed
the
feat/deprecate-without-wrapper
branch
from
October 13, 2022 18:18
0a9f475
to
d9f99d2
Compare
pi0
changed the title
refactor!: reduce node.js handler support
refactor!: reduce node.js dependency
Oct 13, 2022
Codecov Report
@@ Coverage Diff @@
## main #178 +/- ##
==========================================
- Coverage 79.72% 79.21% -0.52%
==========================================
Files 18 19 +1
Lines 1110 1039 -71
Branches 205 208 +3
==========================================
- Hits 885 823 -62
+ Misses 225 216 -9
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to get closer to #73 this change removes support from legacy handler.
Breaking changes for event handlers:
eventHandler()
wrapper otherwise a warning will be shown suggesting to change.(req, res) = {}
are not automatically converted to event handler format. They can now be defined withfromNodeMiddleware((req, res) => {})
Breaking changes for app:
app
instance is not a Node.js listener(req, res)
anymore. It should be converted into usingtoNodeListener(app)
that gives a(req, res)
interface from app.