Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: remove default statusMessage from errors #195

Merged
merged 1 commit into from
Oct 15, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 4 additions & 1 deletion playground/index.ts
Original file line number Diff line number Diff line change
@@ -1,9 +1,12 @@
import { listen } from 'listhen'
import { createApp, createRouter, eventHandler, toNodeListener, parseCookies } from '../src'
import { createApp, createRouter, eventHandler, toNodeListener, parseCookies, createError } from '../src'

const app = createApp({ debug: true })
const router = createRouter()
.get('/', eventHandler(() => 'Hello World!'))
.get('/error/:code', eventHandler((event) => {
throw createError({ statusCode: parseInt(event.context.params.code) })
}))
.get('/hello/:name', eventHandler((event) => {
return `Hello ${parseCookies(event)}!`
}))
Expand Down
11 changes: 8 additions & 3 deletions src/error.ts
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ export class H3Error extends Error {
statusCode: number = 500
fatal: boolean = false
unhandled: boolean = false
statusMessage: string = 'Internal Server Error'
statusMessage?: string = undefined
data?: any
}

Expand Down Expand Up @@ -84,8 +84,13 @@ export function sendError (event: H3Event, error: Error | H3Error, debug?: boole
}

if (event.res.writableEnded) { return }
event.res.statusCode = h3Error.statusCode
event.res.statusMessage = h3Error.statusMessage
const _code = parseInt(h3Error.statusCode as unknown as string)
if (_code) {
event.res.statusCode = _code
}
if (h3Error.statusMessage) {
event.res.statusMessage = h3Error.statusMessage
}
event.res.setHeader('Content-Type', MIMES.json)
event.res.end(JSON.stringify(responseBody, null, 2))
}
Expand Down
3 changes: 1 addition & 2 deletions test/error.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,7 @@ describe('error', () => {

expect(result.status).toBe(500)
expect(JSON.parse(result.text)).toMatchObject({
statusCode: 500,
statusMessage: 'Internal Server Error'
statusCode: 500
})
})

Expand Down