Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: update @deprecated comment #245

Merged
merged 1 commit into from
Nov 23, 2022
Merged

refactor: update @deprecated comment #245

merged 1 commit into from
Nov 23, 2022

Conversation

L422Y
Copy link
Contributor

@L422Y L422Y commented Nov 22, 2022

resolves #246

@danielroe danielroe changed the title Correct @deprecated note docs: update @deprecated comment Nov 22, 2022
@codecov
Copy link

codecov bot commented Nov 22, 2022

Codecov Report

Merging #245 (c8bd5a6) into main (2d08ca3) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #245   +/-   ##
=======================================
  Coverage   75.90%   75.90%           
=======================================
  Files          20       20           
  Lines        1216     1216           
  Branches      224      224           
=======================================
  Hits          923      923           
  Misses        293      293           
Impacted Files Coverage Δ
src/event/event.ts 47.94% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pi0 pi0 changed the title docs: update @deprecated comment refactor: update @deprecated comment Nov 23, 2022
@pi0 pi0 merged commit 1397d51 into unjs:main Nov 23, 2022
@L422Y L422Y deleted the patch-1 branch November 23, 2022 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

It should be "event.node.req" here
3 participants