Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: replace useCookies with parseCookies in describe #314

Merged
merged 1 commit into from
Feb 6, 2023
Merged

test: replace useCookies with parseCookies in describe #314

merged 1 commit into from
Feb 6, 2023

Conversation

ytjmt
Copy link
Contributor

@ytjmt ytjmt commented Feb 5, 2023

It seems that useCookies was replaced with parseCookies in 56bfe0a and dc8ee81. I found useCookies in describe of test/cookie.test.ts and replaced it with parseCookies.

I've confirmed useCookies doesn't exist except in CHANGELOG.

$ git grep useCookies
CHANGELOG.md:* `useCookie`, `useCookies` and `setCookie` utilities ([088f413](https://github.com/unjs/h3/commit/088f413434a619a9888bfd9d1b189e56a7d00124)), closes [#17](https://github.com/unjs/h3/issues/17)

@pi0 pi0 merged commit 9db177f into unjs:main Feb 6, 2023
@pi0
Copy link
Member

pi0 commented Feb 6, 2023

thanks!

@ytjmt ytjmt deleted the replace_use_cookies_with_parse_cookies branch February 6, 2023 11:46
@ytjmt ytjmt mentioned this pull request Feb 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ytjmt @pi0