Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(proxy): separate multiple cookie headers #319

Merged
merged 6 commits into from
Feb 16, 2023
Merged

Conversation

meixger
Copy link
Contributor

@meixger meixger commented Feb 7, 2023

re: #318 proxying multiple cookies and split by comma

@meixger meixger marked this pull request as ready for review February 7, 2023 15:01
@pi0 pi0 changed the title separate multiple cookie headers fix(proxy): separate multiple cookie headers Feb 8, 2023
@codecov
Copy link

codecov bot commented Feb 8, 2023

Codecov Report

Merging #319 (4326fe0) into main (45e6dd4) will increase coverage by 1.07%.
The diff coverage is 97.64%.

❗ Current head 4326fe0 differs from pull request most recent head aa0a14c. Consider uploading reports for the commit aa0a14c to get more accurate results

@@            Coverage Diff             @@
##             main     #319      +/-   ##
==========================================
+ Coverage   70.85%   71.92%   +1.07%     
==========================================
  Files          22       23       +1     
  Lines        1983     2066      +83     
  Branches      289      303      +14     
==========================================
+ Hits         1405     1486      +81     
- Misses        578      580       +2     
Impacted Files Coverage Δ
src/utils/internal/multipart.ts 97.35% <ø> (ø)
src/utils/internal/split-cookies-string.ts 97.43% <97.43%> (ø)
src/utils/body.ts 88.61% <100.00%> (ø)
src/utils/proxy.ts 77.46% <100.00%> (+0.82%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks ❤️

@pi0 pi0 merged commit e5bfd2f into unjs:main Feb 16, 2023
pi0 added a commit to enkot/h3 that referenced this pull request Feb 16, 2023
@oleghalin
Copy link
Contributor

I have problem with this PR, Second cookie from header not applied and found next in the web

Origin servers SHOULD NOT fold multiple Set-Cookie header fields into a single header field. The usual mechanism for folding HTTP headers fields (i.e., as defined in [RFC2616]) might change the semantics of the Set-Cookie header field because the %x2C (",") character is used by Set-Cookie in a way that conflicts with such folding.

What you think @pi0 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants